Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

msg.sender breaks meta transactions in operator-filter registry #90

Open
zcstarr opened this issue Jan 29, 2023 · 0 comments
Open

msg.sender breaks meta transactions in operator-filter registry #90

zcstarr opened this issue Jan 29, 2023 · 0 comments

Comments

@zcstarr
Copy link

zcstarr commented Jan 29, 2023

Summary:
The use of msg.sender in the operator-filter registry makes it impossible to inherit from these classes and override msg.sender. This can be a problem in contexts where the sender may be different than anticipated, such as with EIP-725X.

As a solution, it is recommended to follow the example of OpenZeppelin's contracts and use _msgSender() instead. This will make it easier to consume the operator-filter registry without having to fork the code.

Reference: https://forum.openzeppelin.com/t/why-use-msgsender-rather-than-msg-sender/4370

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant