Integration testing for round restart and multiple rounds #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kellpossible
commented
Jun 13, 2021
•
kellpossible
commented
- Enable testing for changes in Round restart AleoNet/aleo-setup#288, including multiple rounds and having a contributor start part way though a round.
- Remove redundant command line options.
kellpossible
commented
Jun 27, 2021
src/waiter.rs
Outdated
| /// Listen to messages from `rx`, and remove equivalent message | ||
| /// from `expected_messages` until `expected_messages` is empty. | ||
| fn listen<S>( | ||
| mut expected_messages: Vec<T>, |
There was a problem hiding this comment.
this could be refactored, I'm thinking of maybe having some kind of generic waiter with an accumulator and closure that runs over it, and this listen would just be a preset version of that.
There was a problem hiding this comment.
The number of contributions waiter for each contributor_starts could perhaps be implemented with this.
7 tasks
ibaryshnikov
reviewed
Jul 5, 2021
| environment: development, | ||
| round_timout: Some(18000), | ||
| timout: Some(18000), |
ibaryshnikov
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.