Type check negation for unsigned integers.

Author: mikebenfield

compiler/passes/src/type_checking/check_expressions.rs

@@ -970,11 +970,21 @@ impl ExpressionVisitor for TypeChecker<'_> {
             }
             UnaryOperation::Negate => {
                 let type_ = self.visit_expression(&input.receiver, &None);
-                if !matches!(&type_, Type::Err | Type::Integer(_) | Type::Group | Type::Field) {
+                if !matches!(
+                    &type_,
+                    Type::Err
+                        | Type::Integer(IntegerType::I8)
+                        | Type::Integer(IntegerType::I16)
+                        | Type::Integer(IntegerType::I32)
+                        | Type::Integer(IntegerType::I64)
+                        | Type::Integer(IntegerType::I128)
+                        | Type::Group
+                        | Type::Field
+                ) {
                     self.emit_err(TypeCheckerError::type_should_be2(
                         &type_,
-                        "an integer, group, or field",
-                        input.span(),
+                        "a signed integer, group, or field",
+                        input.receiver.span(),
                     ));
                 }
                 type_

tests/expectations/compiler/integers/u8/negate.out

@@ -0,0 +1,9 @@
+namespace = "Compile"
+expectation = "Fail"
+outputs = ["""
+Error [ETYC0372117]: Expected a signed integer, group, or field but type `u8` was found.
+    --> compiler-test:5:17
+     |
+   5 |         return -a;
+     |                 ^
+"""]

tests/expectations/compiler/statements/compare_invalid_negates_fail.out

@@ -1,36 +1,71 @@
 namespace = "Compile"
 expectation = "Fail"
 outputs = ["""
+Error [ETYC0372117]: Expected a signed integer, group, or field but type `u8` was found.
+    --> compiler-test:5:24
+     |
+   5 |         let b: bool = -a == -1u8;
+     |                        ^
 Error [ETYC0372008]: The value -1 is not a valid `u8`
     --> compiler-test:5:29
      |
    5 |         let b: bool = -a == -1u8;
      |                             ^^^^
+Error [ETYC0372117]: Expected a signed integer, group, or field but type `u8` was found.
+    --> compiler-test:6:24
+     |
+   6 |         let c: bool = -a > -1u8;
+     |                        ^
 Error [ETYC0372008]: The value -1 is not a valid `u8`
     --> compiler-test:6:28
      |
    6 |         let c: bool = -a > -1u8;
      |                            ^^^^
+Error [ETYC0372117]: Expected a signed integer, group, or field but type `u8` was found.
+    --> compiler-test:7:24
+     |
+   7 |         let d: bool = -a < -1u8;
+     |                        ^
 Error [ETYC0372008]: The value -1 is not a valid `u8`
     --> compiler-test:7:28
      |
    7 |         let d: bool = -a < -1u8;
      |                            ^^^^
+Error [ETYC0372117]: Expected a signed integer, group, or field but type `u8` was found.
+    --> compiler-test:8:24
+     |
+   8 |         let e: bool = -a >= -1u8;
+     |                        ^
 Error [ETYC0372008]: The value -1 is not a valid `u8`
     --> compiler-test:8:29
      |
    8 |         let e: bool = -a >= -1u8;
      |                             ^^^^
+Error [ETYC0372117]: Expected a signed integer, group, or field but type `u8` was found.
+    --> compiler-test:9:24
+     |
+   9 |         let f: bool = -a <= -1u8;
+     |                        ^
 Error [ETYC0372008]: The value -1 is not a valid `u8`
     --> compiler-test:9:29
      |
    9 |         let f: bool = -a <= -1u8;
      |                             ^^^^
+Error [ETYC0372117]: Expected a signed integer, group, or field but type `u8` was found.
+    --> compiler-test:10:22
+     |
+  10 |         let g: u8 = -a * -1u8;
+     |                      ^
 Error [ETYC0372008]: The value -1 is not a valid `u8`
     --> compiler-test:10:26
      |
   10 |         let g: u8 = -a * -1u8;
      |                          ^^^^
+Error [ETYC0372117]: Expected a signed integer, group, or field but type `u8` was found.
+    --> compiler-test:11:22
+     |
+  11 |         let h: u8 = -a ** -1u8;
+     |                      ^
 Error [ETYC0372008]: The value -1 is not a valid `u8`
     --> compiler-test:11:27
      |

tests/tests/compiler/integers/u8/negate.leo

@@ -0,0 +1,10 @@
+/*
+namespace = "Compile"
+expectation = "Fail"
+*/
+
+program test.aleo {
+    transition main(a: u8) -> u8 {
+        return -a;
+    }
+}