Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query value not encode correctly after map remote. #2193

Open
Sourgrapes42 opened this issue Nov 20, 2024 · 3 comments
Open

Query value not encode correctly after map remote. #2193

Sourgrapes42 opened this issue Nov 20, 2024 · 3 comments
Assignees
Labels
bug Something isn't working ✅ Done Ticket is addressed and fixed.

Comments

@Sourgrapes42
Copy link

Description

Query value not encode correctly after map remote when query value contains +

Steps to Reproduce

  1. Add a map remote rule likehttps://proxyman.io/ -> https://docs.proxyman.io/
    image

  2. Make a requset which query value contains urlencoded + like https://proxyman.io/?data=abc%2B123

image
  1. Check it at Proxyman, you will see the url changed into https://docs.proxyman.io/?data=abc+123
    image

Current Behavior

Proxyman decode %2B to +

Expected Behavior

Keep %2B at query value, the url should be https://docs.proxyman.io/?data=abc%2B123

Environment

  • App version: Proxyman 5.10.0
  • macOS version: macOS 14.6.1
@Sourgrapes42 Sourgrapes42 added the bug Something isn't working label Nov 20, 2024
@NghiaTranUIT
Copy link
Member

It's expected behavior because + in the query should be percent-encoded. encodeURIComponent() has the same rule.

Screenshot 2024-11-24 at 16 19 53

@Sourgrapes42
Copy link
Author

The origin + is encoded to %2B, but after Proxyman map remote, %2B is decode to +.
E.g. map https://proxyman.io/ to https://docs.proxyman.io/. When request to https://proxyman.io/?data=abc%2B123 Proxyman should request https://docs.proxyman.io/?data=abc%2B123. but Proxyman change %2B to + and requset https://docs.proxyman.io/?data=abc+123

@NghiaTranUIT NghiaTranUIT self-assigned this Dec 3, 2024
@NghiaTranUIT
Copy link
Member

@Sourgrapes42 it's fixed in this build: #2202 (comment)

@NghiaTranUIT NghiaTranUIT added this to the Proxyman 5.12.0 milestone Dec 3, 2024
@NghiaTranUIT NghiaTranUIT added the ✅ Done Ticket is addressed and fixed. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ✅ Done Ticket is addressed and fixed.
Projects
None yet
Development

No branches or pull requests

2 participants