Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 沒有access token應該要可以看到/v1/popular-articles熱門文章列表 #244

Open
titaneric opened this issue Jun 27, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@titaneric
Copy link
Contributor

發生了什麼事? / The Problem

在不放入Access Token 的情況下 GET /v1/popular-articles 應該出現熱門文章列表,上限為 100 個文章。但是回傳空列表。

如何重現 / To Reproduce

  1. curl http:localhost:8081/v1/popular-articles
  2. 回傳空列表

預期的行為 / Expected behavior

應該要回傳熱門文章列表

螢幕截圖 / Screenshots

image

開發環境 / Environment

  1. OS: Windows 10 and WSL 2 Ubuntu 20.04
  2. Go version v1.16.5
@titaneric titaneric added the bug Something isn't working label Jun 27, 2021
@ichiaohsu
Copy link
Contributor

看起來 go-bbs 還沒有實作

@PichuChen
Copy link
Member

go-bbs應該不會實作這個,他一開始就沒有存在於PTT 應該是另外在PTT-backend 做統計就行了

@ichiaohsu
Copy link
Contributor

go-bbs應該不會實作這個,他一開始就沒有存在於PTT 應該是另外在PTT-backend 做統計就行了

原來如此!我看註解覺得好像會有 go-bbs 的實作,雖然沒看到有對應的 interface 定義。

@PichuChen
Copy link
Member

這個ISSUE存在和 #117 還沒有實作有關

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants