Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support recurring events #9

Open
IcyApril opened this issue Nov 18, 2016 · 2 comments
Open

Doesn't support recurring events #9

IcyApril opened this issue Nov 18, 2016 · 2 comments

Comments

@IcyApril
Copy link

GetEventsByDate doesn't include recurring events.

@PuloV
Copy link
Owner

PuloV commented Nov 19, 2016

Hi,
You should get the recurring events with the GetEventsByDate because of
https://github.com/PuloV/ics-golang/blob/master/calendar.go#L89
and all event when parsed are added with SetEvent
https://github.com/PuloV/ics-golang/blob/master/parse.go#L262

Can you check if the needed event is in the data returned by GetEvents

Can you also check if the
https://github.com/PuloV/ics-golang/blob/master/parse.go#L15
ics.RepeatRuleApply and ics.MaxRepeats are set correctly

2016-11-18 12:15 GMT+02:00 Junade [email protected]:

GetEventsByDate doesn't include recurring events.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#9, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADlKwGlOIRsr_HcglGMBfQoTIaWUq1hZks5q_XqpgaJpZM4K2Ug_
.

@buildscientist
Copy link
Contributor

@PuloV functionality exists but I don't see any tests for this. Recommend we write an explicit test for this as we already have test data with recurring events. Otherwise I'd close this out since it's almost 3 years old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants