Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some words are not highlighted when selected in large files #199

Open
KyNorthstar opened this issue May 3, 2019 · 2 comments
Open

Some words are not highlighted when selected in large files #199

KyNorthstar opened this issue May 3, 2019 · 2 comments

Comments

@KyNorthstar
Copy link

[Enter steps to reproduce:]

  1. Load a large file (My test is 10MB)
  2. Select a highlightable word

Atom: 1.36.1 x64
Electron: 2.0.18
OS: Mac OS X 10.13.6
highlight-selected: 0.16.0
Demonstration video: https://photos.app.goo.gl/Au1vY9cbvBDw5Yi68

Non-Core Packages

atom-material-syntax 1.0.8 
atom-material-syntax-dark 1.0.0 
atom-material-ui 2.1.3 
busy-signal 2.0.1 
highlight-selected 0.16.0 
intentions 1.1.5 
language-log 1.10.1 
language-swift 0.5.0 
linter 2.3.0 
linter-ui-default 1.7.1 
minimap 4.29.9 
minimap-bookmarks 0.4.2 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-highlight-selected 4.6.1 
minimap-linter 2.2.1 
minimap-pigments 0.2.2 
minimap-selection 4.5.0 
Sublime-Style-Column-Selection 1.7.5 
@richrace
Copy link
Member

richrace commented May 3, 2019

Do you have the status bar enabled? If so you can easily see how many highlights have been added.

There's a setting that limits the number of highlights Maximum Highlights which is defaulted to 500.

See #193 for motivation.

@JuliusNmn
Copy link

This makes the plugin essentially useless for too large files. There should be an option to search for occurrences only inside currently visible section of the file being edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants