Teleport de-sync

[Alvsch]

I've searched existing issues and couldn't find a duplicate.

• I confirm this is not a duplicate.

Operating System

Manjaro Linux

Server Software Version/Commit

f29cfbc

What happened?

Player position gets de-synced between clients when teleporting more than 8 blocks. This results in the player falling through the ground on other players POV.

To Reproduce

/teleport ~ ~10 ~
You should then be in the ground for other players when falling to the ground.

Expected behavior

Teleport 10 blocks up and then fall down stopping at the ground for all players.

[Commandcracker]

Can confirm 👍

[DataM0del]

I think I've had this months ago.

[Snowiiii]

I think it is because of the relative PositionFlags which are not being send (we just use an empty array)

[Witcher01]

@Snowiiii I don't think that's the case:

In the lower 8 bits of the bit field, a set bit means the teleportation on the corresponding axis is relative, and an unset bit that it is absolute.

https://minecraft.wiki/w/Minecraft_Wiki:Projects/wiki.vg_merge/Protocol#Teleport_Flags

Not setting any bits there means the teleportation is absolute, not relative. The teleportation itself works because the coordinates always seem to be given as absolute ones. All argument consumers used for teleporation with positions are Position3DArgumentConsumers, which convert the relative position to an absolute one when the arguments are parsed in the dispatcher. Given that teleporting works in principal, even with relative coordinates, this shouldn't be the issue from what I can see.

Setting some of the bits didn't solve the issue for me, either.

I think it's fair to remove the "good first issue" label from this one.