Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreman scenarios are lacking sane defaults #31

Open
mattock opened this issue Jul 23, 2018 · 0 comments
Open

Foreman scenarios are lacking sane defaults #31

mattock opened this issue Jul 23, 2018 · 0 comments
Assignees

Comments

@mattock
Copy link
Member

mattock commented Jul 23, 2018

The Foreman scenarios (foreman_proxy and lcm) depended heavily on sane defaults stored in answer files. Now the answer files are empty, so the default values are missing. Add sane defaults which can be used reasonably in any environment.

A related problem is defaults for Vagrant, which can be considered a special environment with additional sane defaults. My proposed solution is this:

  • Add generic, sane defaults to foreman_proxy.pp and lcm.pp
  • Create an answer file suitable for the Vagrant environment
  • Store and version the answer file
  • Ensure that the default (almost empty) answer file is overwritten during Vagrant provisioning with the answer file tailored for Vagrant

This way Vagrant-specifisms don't accidentally end up in production environments.

kibahop pushed a commit to kibahop/puppet-puppetmaster that referenced this issue Sep 19, 2018
Foreman was lacking default parameters, resulting to undefs and failing.
This commit adds default parameters to the class.

URL: Puppet-Finland#31

Signed-off-by: Petri Lammi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants