Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db management system libraries for rest of the databases #298

Closed
wants to merge 18 commits into from

Conversation

cyanogus
Copy link
Contributor

This was added for the currency system's database. Since no problems were reported from use after it's implementation, I feel like it's time to implement this change to the other databases as well.

@cyanogus
Copy link
Contributor Author

So far I've worked on the levelling db part of it. I'm currently working on the items db part and the other ones are yet to be completed.

@cyanogus
Copy link
Contributor Author

Added database library support for weather cog.

@cyanogus cyanogus marked this pull request as draft July 4, 2023 05:00
@cyanogus
Copy link
Contributor Author

Alternative pull request was made for Weather DB commands. #310
Another alternative pull request was also made for Levelling DB commands. #307

@notsniped notsniped self-assigned this Oct 20, 2023
@notsniped
Copy link
Member

notsniped commented Oct 20, 2023

This PR contains the following topics which need to be replicated in other PRs:

  • Items
  • Levels
  • Weather

@notsniped
Copy link
Member

Am currently working on items db support.

@notsniped
Copy link
Member

notsniped commented Oct 20, 2023

Functions that need to be added for items db

  • load() - Loads the database into a variable
  • save() - Dumps the variable data into local machine db
  • generate() - Generates a new key for the user (and adds any missing item values), but skips if user already exists
  • add_item() - Adds an item of a specified quantity
  • remove_item() - Removes an item of a specified quantity
  • fetch_item_count() - Returns the number of a specified item a user has in their inventory

@notsniped notsniped added wontfix This will not be worked on priority:high labels Oct 20, 2023
@notsniped notsniped added type:libraries Changes to the imports/structure of imports or internal libraries area:storage Changes made to the systems required for storing, modifying and accessing of user data. area:main Changes to the main functioning code area:framework Any changes to the NKA Framework for isobot type:cogs Any changes to the bot's slash command cogs type:code quality Anything that improves the source's code quality labels Oct 20, 2023
@notsniped
Copy link
Member

A new pull request for base implementation of items db has been made.
#312

@notsniped
Copy link
Member

Now, for the items db, full migration of commands using items, and testing will be done.

@notsniped
Copy link
Member

A complete version of items db was made at #313

@notsniped
Copy link
Member

The PRs mentioned above have covered all of the changes of this one PR. This PR will now be closed. Thank you for your time!

@notsniped notsniped closed this Oct 23, 2023
@notsniped
Copy link
Member

PRs: #307 #310 #312 #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:framework Any changes to the NKA Framework for isobot area:main Changes to the main functioning code area:storage Changes made to the systems required for storing, modifying and accessing of user data. priority:high size/L type:code quality Anything that improves the source's code quality type:cogs Any changes to the bot's slash command cogs type:libraries Changes to the imports/structure of imports or internal libraries wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants