Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#noqa no longer works in 1.7.1 #226

Closed
tuukkamustonen opened this issue Jun 1, 2023 · 2 comments
Closed

#noqa no longer works in 1.7.1 #226

tuukkamustonen opened this issue Jun 1, 2023 · 2 comments
Labels
S: invalid Closed as invalid with respect to docformatter

Comments

@tuukkamustonen
Copy link

This used to work in 1.7.0 and earlier:

class Foobar:
    # noqa
    """some gibb
    erish
    """

1.7.1 formats it despite # noqa.

By the way couldn't find any mention of noqa support in the docs? Should it be advertized?

@github-actions github-actions bot added the fresh This is a new issue label Jun 1, 2023
@weibullguy weibullguy added S: invalid Closed as invalid with respect to docformatter and removed fresh This is a new issue labels Jun 1, 2023
@weibullguy
Copy link
Member

docformatter has never recognized the # noqa decorator. I ran your snippet through v1.7.1, v1.7.0, and v1.6.0 and, as it should, docformatter reformatted the docstring. Please see #144 for a request to provide the ability to ignore part or all of a docstring.

@tuukkamustonen
Copy link
Author

That's interesting, because the behavior differs in our codebase. Well, don't have time to dive deeper here, so will just stick with older version until #144 😎

Thanks for the project, appreciate your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: invalid Closed as invalid with respect to docformatter
Projects
None yet
Development

No branches or pull requests

2 participants