Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple files support #97

Closed
wants to merge 1 commit into from

Conversation

Yourun-proger
Copy link

@Yourun-proger Yourun-proger commented Mar 20, 2022

resolves #94
I've added support for entering multiple arguments as files to check for complexity.
I also added handling of the case when the user does not enter anything as an argument for CLI.

@Yourun-proger
Copy link
Author

Will there be any comments about this pull request?

@The-Compiler
Copy link
Member

See #84, #73, #65 - you might want to use mccabe via flake8 (as intended) rather than a standalone tool.

@Yourun-proger
Copy link
Author

Well, if this update is not needed, i can close this pull request. True, in this case, it is worth closing the original issue

@Yourun-proger
Copy link
Author

Should this PR be closed?

@The-Compiler
Copy link
Member

I'll leave that to whoever is maintaining this project - while a PyCQA member, I've never done anything in mccabe (I just happen to use it). But judging from there, the chances of this being accepted are probably slim, sorry.

@Yourun-proger
Copy link
Author

Nevermind, I just wanted to hear some feedback) I guess I'll close this. If the maintainers still like it, they can reopen it. Thanks anyway!

@jrom99
Copy link

jrom99 commented Mar 29, 2022

See #84, #73, #65 - you might want to use mccabe via flake8 (as intended) rather than a standalone tool.

Still, wouldn't it be better for it to raise more descriptive errors? IMO a ValueError or even TypeError in both cases would be more helpful than the current behavior or IndexError/ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add a check for none/multiple positional arguments
3 participants