Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete set of optical models #55

Open
domna opened this issue Jun 29, 2022 · 2 comments
Open

Complete set of optical models #55

domna opened this issue Jun 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@domna
Copy link
Member

domna commented Jun 29, 2022

Have at least all models from Fujiwara implemented.

@domna domna added the enhancement New feature or request label Jun 29, 2022
@domna
Copy link
Member Author

domna commented Jun 29, 2022

Implemented

  • Sellmeier
  • Cauchy
  • Lorentz
  • Drude
  • Harmonic Oscillator Approximation
  • Gaussian
  • Tauc-Lorentz

Need KKR

  • Cody-Lorentz
  • CP Models
  • Polynomials, Splines and B-Spline

Checked

This means three things:

  • The docstring is checked (correct formula and general appearance)
  • The formula is the same as in Fujiwara
  • The formula in the docstring and the actual returned value are the same
  • It contains a note if the dispersion is not summable (all n-based dispersions, currently two Cauchys and ConstantRefractiveIndex)

List

  • Sellmeier
  • Cauchy
  • Lorentz
  • Drude
  • Harmonic Oscillator Approximation
  • Gaussian
  • Tauc-Lorentz
  • Cody-Lorentz
  • CP Models
  • Polynomials, Splines and B-Spline

Models present in pyElli but not in Fujiwara

  • Poles
  • Tanguy

@domna
Copy link
Member Author

domna commented Jun 30, 2022

Maybe also have a look at Sentech and Woolam docs to see what they have to offer and implement that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant