Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoding option for ftpfs #281

Open
frafra opened this issue Oct 6, 2021 · 0 comments
Open

Support encoding option for ftpfs #281

frafra opened this issue Oct 6, 2021 · 0 comments

Comments

@frafra
Copy link

frafra commented Oct 6, 2021

I am fetching data from a Windows FTP server, which contains some special characters.

Python built-in ftplib can use a different encoding: https://docs.python.org/3/library/ftplib.html#ftplib.FTP

class ftplib.FTP(host='', user='', passwd='', acct='', timeout=None, source_address=None, *, encoding='utf-8')¶

ftpfs does not take "encoding" as parameter:

ftp = FTP()

I propose to accept encoding as an optional parameter, which should then passed to the FTP constructor.

It would then be possible to connect to resources like: ftp://user:password@ftpserver/path?encoding=windows-1252

@frafra frafra changed the title Support encoding option Support encoding option for ftpfs Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant