Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why mountfs doesn't provide unmount #538

Open
davidleon opened this issue May 10, 2022 · 1 comment
Open

why mountfs doesn't provide unmount #538

davidleon opened this issue May 10, 2022 · 1 comment

Comments

@davidleon
Copy link

don't know the design choice here, why the underlying mounts var is not implemented as a dict?(performance issue? considering mount points are relatively small list. i think it's better to clarify in the source code.)

the following is my implementation for the current implementation.

def umount(self, path):
    _path = forcedir(abspath(normpath(path)))
    for mount_path, fs in self.mounts:
        if _path.startswith(mount_path):
            self.mounts.remove((mount_path,fs))
@lurch
Copy link
Contributor

lurch commented May 10, 2022

See #487 which I need to take a second look at, at some point 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants