Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove HamiltonDeck.load_from_lay_file (August 1) #182

Closed
rickwierenga opened this issue Jun 28, 2024 · 1 comment
Closed

remove HamiltonDeck.load_from_lay_file (August 1) #182

rickwierenga opened this issue Jun 28, 2024 · 1 comment
Assignees

Comments

@rickwierenga
Copy link
Contributor

I deprecated this because parsing lay files (deck files) relies on imported VENUS-resources, which are also deprecated due to incompleteness and incorrectness. See #172 and #170.

We could load them from rck files which we search on the system, but that's more work for a feature that is barely used. They are also likely to be incorrect definitions. Also, in the future it's unlikely we will be able to load venus resources from rck files because we will require more information than venus offers.

@rickwierenga
Copy link
Contributor Author

1a99c49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant