Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation refers to adding route and view in the one add_route call. #3551

Closed
arterrey opened this issue Dec 25, 2019 · 2 comments
Closed
Milestone

Comments

@arterrey
Copy link

Documentation states:

Add a route configuration to the current configuration state, as well as possibly a view configuration to be used to specify a view callable that will be invoked when this route matches

(https://docs.pylonsproject.org/projects/pyramid/en/latest/api/config.html#pyramid.config.Configurator.add_route)

However there is no reference to any view configuration that can be passed into add_route Furthermore, a the comment (#2852 (comment)) on another issue indicates that this functionality was removed.

@stevepiercy
Copy link
Member

stevepiercy commented Dec 25, 2019

@arterrey checking git blame of the docstrings, and that there are no "view-related types", I would say you found an artifact in the docstrings that needs to be updated. The Pyramid Change History for 1.1a1 under Deprecations also states:

Passing view-related parameters to pyramid.config.Configurator.add_route is now deprecated.

Would you please submit a PR against the master branch?

@mmerickel mmerickel added this to the 2.0 milestone Jan 17, 2020
@merwok
Copy link
Contributor

merwok commented Jan 17, 2020

Fixed by c1e150d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants