Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor tests are always "passing" #4

Closed
whart222 opened this issue Jun 8, 2016 · 8 comments
Closed

Appveyor tests are always "passing" #4

whart222 opened this issue Jun 8, 2016 · 8 comments
Milestone

Comments

@whart222
Copy link
Member

whart222 commented Jun 8, 2016

The root cause may be the return value for test.pyomo.exe. I suspect that it's not returning a nonzero value when a test fails.

@whart222 whart222 added this to the Pyomo 5.x milestone Jun 8, 2016
@whart222
Copy link
Member Author

whart222 commented Jun 8, 2016

Does anyone have a Windows box that they can test this on?

ghackebeil added a commit to PyUtilib/pyutilib that referenced this issue Jun 18, 2016
…re code when tests fail. Need to call sys.exit (references Pyomo/pyomo#4)
@ghackebeil
Copy link
Member

Ah, I think I know what the problem is. We are testing Pyomo trunk against the latest PyUtilib release. So the various fixes I have been making in PyUtilib that are referenced above are not even being tested on appveyor (or travis).

@ghackebeil
Copy link
Member

It looks like the series of fixes I've made on PyUtilib trunk (starting at PyUtilib/pyutilib@dfa78b4) along with the updates to the appveyor (and travis) script to install PyUtilib trunk (6cc8409) have fixed this.

Now we just need to understand why the test script output on appveyor is a few thousand lines of empty space. Something I am going to leave for another day...

ghackebeil added a commit to PyUtilib/pyutilib that referenced this issue Jun 27, 2016
@ghackebeil
Copy link
Member

It looks like the tee keyword for pyutilib.subprocess.run has a strange interaction with the appveyor console output. If you look at the raw log file, all of the test output is there. It's just the live output that appveyor is directing to the webpage is nothing bu blank lines.

@jsiirola will have to investigate this further, as I think he has done the most work on output redirection in that function. Also, this should technically be reopened as a pyutilib issue at this point.

@whart222
Copy link
Member Author

whart222 commented Jul 6, 2016

There is a new branch for PyUtilib, issue-22, that is focused on addressing this issues. Once this branch is resolved, we should generate a new PyUtilib release, which will allow us to close this issue.

@qtothec
Copy link
Contributor

qtothec commented Jan 3, 2018

This was resolved, right?

@whart222
Copy link
Member Author

whart222 commented Jan 3, 2018

I'll let @jsiirola comment. I think he fixed the Appveyor tests, but not by fixing the PyUtilib issue-22. (Right?)

@jsiirola
Copy link
Member

jsiirola commented Jan 4, 2018

This is definitely fixed for Pyomo. I will close this issue.

I am not sure on the status of PyUtilib/pyutilib#22.

@jsiirola jsiirola closed this as completed Jan 4, 2018
michaelbynum referenced this issue in michaelbynum/pyomo Feb 24, 2020
Merge master into solver-rewrite
michaelbynum added a commit that referenced this issue May 21, 2020
solver class, memory reallocation, and regularization
kaklise pushed a commit to kaklise/pyomo that referenced this issue Jun 30, 2021
Update Pyomo fork with units fixes
blnicho pushed a commit that referenced this issue Jan 30, 2023
Update doe-review with pyomo/main
blnicho pushed a commit that referenced this issue May 7, 2024
djlaky pushed a commit to djlaky/pyomo that referenced this issue May 25, 2024
blnicho pushed a commit that referenced this issue Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants