Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Thread Safety] Shouldn't call Bukkit API asynchronously #137

Open
Summiner opened this issue Mar 23, 2024 · 0 comments
Open

[Thread Safety] Shouldn't call Bukkit API asynchronously #137

Summiner opened this issue Mar 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Summiner
Copy link

Summiner commented Mar 23, 2024

Throughout this project there are multiple cases of calling Placeholderapi#setPlaceholders asynchronously which is technically unsafe behavior. This was brought to my attention by a friend when doing the same thing myself. This doesn't cause any issues in the surface however it should ideally be resolved to prevent any potential thread safety issues.

An example of doing this property can be found here:
https://github.com/NEZNAMY/TAB/blob/9a6d309840414081b867838ea1d59b38a005e79d/bukkit/src/main/java/me/neznamy/tab/platforms/bukkit/platform/BukkitPlatform.java#L219

@Pyrbu Pyrbu added the bug Something isn't working label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants