Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Optimization Request] Stop shading packetevents #149

Open
rafi67000 opened this issue Aug 19, 2024 · 1 comment
Open

[Feature/Optimization Request] Stop shading packetevents #149

rafi67000 opened this issue Aug 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rafi67000
Copy link

rafi67000 commented Aug 19, 2024

Hi!
It's better to depend on external packetevents due to (for example):

  1. users can manually update packetevents (for example to dev build with hotfixes)
  2. better performance (packets have to be encoded/decoded multiple times)
  3. smaller jar size
@Pyrbu Pyrbu added the enhancement New feature or request label Sep 5, 2024
@Pyrbu
Copy link
Owner

Pyrbu commented Sep 5, 2024

The only reason we aren't currently using external packet events is that I'm personally against having to install "dependency" plugins for the simple reason that it introduces more issues when installing the plugin for users which means we need to provide more support.

I've also looked into supporting both the plugin and the shaded version but the issue with that is the plugin would need to load the classes at runtime if the plugin isn't present which is currently almost impossible due to Paper's decision to remap plugins at server start time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants