Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA methods to perform barycentric mapping when input is close enough rather than exactly equal to source #529

Open
kachayev opened this issue Oct 1, 2023 · 0 comments

Comments

@kachayev
Copy link
Collaborator

kachayev commented Oct 1, 2023

🚀 Feature

Some DA transports provide a barycentric mapping "shortcut" when performing transformation of the input that is equal to the original set of source samples used for fitting. See BaseTransport (here) and MappingTransport (here) as examples.

The proposal is to use allclose instead of array_equal. In fact, it's already done this way for JCPOTTransport.

Motivation

Equality is a rather strong when working with floats. It seems like checking if two arrays are element-wise equal within a tolerance fits the use case. We could also make tolerance into optional parameter for the corresponding transport constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant