Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous and discrete variables as attribute to the preprocessor #175

Open
patrickleonardy opened this issue May 15, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@patrickleonardy
Copy link
Contributor

Add continuous and discrete variables as attributes to the Preprocessor

Problem:
Currently we have to pass continuous and discrete variable names to the fit and transform functions of the Preprocessor It would be better to pass those variable names only once to the fit function and then reuse this information in the transform function.

Reason:
As far as I am aware, the columns should never change for the Preprocessor so why should we pass them several times to the same object? Passing lists that are supposed to stay the same several times can cause errors and can also confuse the user.

Task Description

  1. This issue will add continuous and discrete variable names as attributes to the Preprocessor object to be able to define those only once in the fit function or in the object creation.
  2. The Preprocessor then should be refactored to use this attribute
  3. Check if everything is still working as expected

Note:

The Preprocessor should still be able to preprocess a DataFrame that contains not all the variables (in case we want to use the same Preprocessor with data where a column is missing).

@patrickleonardy patrickleonardy added this to the 2023-05 milestone May 15, 2023
@patrickleonardy patrickleonardy added the enhancement New feature or request label May 15, 2023
@patrickleonardy patrickleonardy self-assigned this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant