Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are module proguard rules used? #85

Open
ninovanhooff opened this issue Nov 13, 2024 · 1 comment
Open

Are module proguard rules used? #85

ninovanhooff opened this issue Nov 13, 2024 · 1 comment

Comments

@ninovanhooff
Copy link
Collaborator

I feel like it's only the app/proguard-rules.pro that is being used.

I checked Hema, Wie Is De Mol, Rijksmuseum.

Only Hema had content in the core module proguard-rules.pro. Diffing that with the app version, there seems to be nothing in the core version tha isn't in the app version. Should we remove the module proguard files to avoid confusion?

@ninovanhooff
Copy link
Collaborator Author

ninovanhooff commented Nov 13, 2024

Proguard is only relevant for the actual release. So instead of adding minifyEnabled true for every module, only add it for to the release configuration of the app itself.

https://stackoverflow.com/a/50819864/923557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant