-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-100] Main modules for data and domain #110
base: develop
Are you sure you want to change the base?
Conversation
issue100/data-domain-main-modules
issue100/data-domain-main-modules
@@ -134,6 +134,10 @@ We use [Clean Architecture](#inspiration-material), to a very large extend. Our | |||
|
|||
 | |||
|
|||
Note that the image shows separate modules per feature for domain and data (ie. data:user and domain:user). It is recommended for larger projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where the source for the image lives and whether it should be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what happens if you paste an image in a comment/readme or other textfield on GH.
Judging from this page it doesn't have a lifetime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @ninovanhooff means the document from which an app created the PNG because that PNG becomes incorrect with this PR.
TBH, I don't know, maybe @Frank1234 has the original document somewhere on his computer, you might want to wait until next week when he's back before merging the PR.
FYI: For McDonald's I'm using the kind of graph you see below from an online tool called https://excalidraw.com/ here you can work for free and save the document to a .excalidraw
file that I commit to the repo together with the image to make sure it can be updated.
Why is this important?
tl;dr: Before, domain and data modules were split by feature (domain/user, domain/artice and data/user, data/article were modules).
This introduces maintenance overhead for small projects. Because most projects that are created from this template are small projects, that is unwanted.
Notes
When reviewing, notice that this PR is a refactor and many of the changes involves moving a file to a new location