New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naming: criterion.py could be criterions.py #64

Open

mathurinm opened this issue Dec 17, 2020 · 3 comments

Collaborator

mathurinm commented Dec 17, 2020

models.py is already plural, which makes more sense for me

wdyt @QB3 @Klopfe ?

Collaborator

svaiter commented Dec 17, 2020

You mean criteria.py right? ;)

Collaborator Author

mathurinm commented Dec 17, 2020

ah... that's bad because correctness would make the access harder to me

Collaborator

agramfort commented Dec 17, 2020 via email

any choice of plural or not is fine for me. Let's jut be consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment