Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on Weighted Lasso example with held-out test set #95

Open
ksehic opened this issue Feb 5, 2021 · 3 comments
Open

Comments on Weighted Lasso example with held-out test set #95

ksehic opened this issue Feb 5, 2021 · 3 comments

Comments

@ksehic
Copy link

ksehic commented Feb 5, 2021

Hi @QB3 @mathurinm

About the weighted Lasso example, it seems you are using kfold for training sparse-ho crossval function, then why are you passing indices in heldout function line 80? It should be HeldOutMSE(None, None)?

It would be nice when you are splitting to have X_train y_test instead of passing again X and y. I have noticed that the number of training samples could be too small. As you can see if we have more samples, sparse-ho is doing better....

image

image

@QB3
Copy link
Owner

QB3 commented Feb 8, 2021

It should be HeldOutMSE(None, None)?

Yes you are right! thx!

@QB3
Copy link
Owner

QB3 commented Feb 8, 2021

Btw I think I should replace 'WeightedLasso val' by 'WeightedLassoCV' wdyt?

@mathurinm
Copy link
Collaborator

and put LassoCV test, too ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants