Fix and prettify #24
Merged
Fix and prettify #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: also changes the compathelper main branch to |
AntonReinhard
added a commit
that referenced
this pull request
Sep 14, 2024
This reverts commit 5a70448.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generation code has been improved a bit and now makes use of the new edge sorting in
ComputableDAGs. This allows a lot of thecomputeoverloads to be removed.I compared the results for Compton scattering processes with single spin/pol combinations with the results of the previous implementation and fixed things to make them equal.
I also improved the initial
Propagatortasks so they now require almost no allocations, and generally improved the compute functions so the profiler now essentially only shows time spent in*,+, andRuntimeGeneratedFunctions-related overhead.