-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release to main #51
Release to main #51
Conversation
Release version 0.1.0
- only if the target branch is not main
CI: set QED dependencies for doc build to dev branch version, if target branch is not main
Fix branch names and julia version number in CI
Co-authored-by: Uwe Hernandez Acosta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM.
Why do you think, the integration tests with QuantumElectrodynamics.jl
will fail? Still a bug in the CI?
No, the CI works fine. But as you can see in the release integration test of QED.jl, the test fails because fields has not been released again yet, so it doesn't work. https://gitlab.com/hzdr/qedjl-project/QEDevents-jl/-/jobs/8219785901 I think we should just increase the minor version after all. |
6bf5f88
to
7db12cb
Compare
I'm not sure if a patch version increase is enough, but technically no breaking changes were introduced. The QuantumElectrodynamics.jl integration tests might fail though.
Do not squash.