Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of the pseudopotential schema #2

Open
giannozz opened this issue Sep 23, 2020 · 1 comment
Open

Status of the pseudopotential schema #2

giannozz opened this issue Sep 23, 2020 · 1 comment

Comments

@giannozz
Copy link

The current pseudopotential schema, v.0.99, is implemented in the upflib/ library. It requires some testing of course, but it should more or less work both in writing (write_upf_new.f90) and in reading (read_upf_new.f90) codes. The upfconv.f90 utility should also work. The schema for the GIPAW section should however be slightly modified (see also the FIXME's in read_upf_new.f90):

  • pp_gipaw_core_orbital
  • pp_gipaw_orbital

should be preceded by, or included into, a tag containing the information on the number or respective orbitals. This would make reading the xml file in a SAX style, as done by the xmltools.f90 utilities, much easier.

@pietrodelugas
Copy link
Member

pietrodelugas commented Sep 29, 2020

the two sections were already in the schema, just I omitted to write them, probably planning to remove them from the schema.
to spare two tags we could turn these two elements as attributes. What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants