-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions for BSM2 module #44
Comments
ADM/Anaerobic Digester
|
Primary Clarifier
|
Currently the After providing some initial conditions the system can miraculously run, but the results are awfully wrong... |
Would you be able to join the office hour today? If no one shows up, we can work on this together.
|
yep that's my plan, thanks & talk to you later!
|
@joyxyz1994 I tried to run the test for the If you've gotten the results close enough to the matlab model, can you send in a PR to merge into main? Thanks! |
I used |
Ah if that's the case let's wait till that's figured out - I just realized that we need to merge in the updates in ***@***.***
I'll rerun the tests locally, I thought I was using the exact same branches as you and I pulled in the recent changes....
…________________________________
From: Xinyi Joy Zhang ***@***.***>
Sent: Tuesday, April 30, 2024 6:00 PM
To: QSD-Group/EXPOsan ***@***.***>
Cc: Yalin ***@***.***>; Author ***@***.***>
Subject: Re: [QSD-Group/EXPOsan] Questions for BSM2 module (Issue #44)
I used ***@***.*** and ***@***.*** The maximum relative error I got was around 0.018. I didn't merge because I haven't checked the other sludge treatment units that Saumitra developed yet. Would you prefer we merge anyway?
—
Reply to this email directly, view it on GitHub<#44 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALV5VLL2JHXDGIFXOODT2DTZAAH6RAVCNFSM6AAAAAA7IE6GOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBXGQ4TQMRSGQ>.
You are receiving this because you authored the thread.
|
Documenting questions related to implementing the BSM2 configuration in EXPOsan: https://github.com/QSD-Group/EXPOsan/tree/bsm2/exposan/bsm2
Tables, etc. below refer to the BSM2 report if not otherwise noted: http://iwa-mia.org/wp-content/uploads/2022/09/TR3_BSM_TG_Tech_Report_no_3_BSM2_General_Description.pdf
The text was updated successfully, but these errors were encountered: