Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] New discord update broke the plugin #396

Open
roller59 opened this issue Jun 22, 2024 · 5 comments
Open

[BUG] New discord update broke the plugin #396

roller59 opened this issue Jun 22, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@roller59
Copy link

The new update made the plugin unusable, just getting the notif that it cant start. Also are there any alternatives to it by any chance? Thnaks in advance

@roller59 roller59 added the bug Something isn't working label Jun 22, 2024
@thehamish555
Copy link

thehamish555 commented Jun 23, 2024

i made a pull request that has a fix for this made by someone on reddit, seems to work
#397

@roller59
Copy link
Author

i made a pull request that has a fix for this made by someone on reddit, seems to work #397

Thank you so much

@Leah96xxx
Copy link

InAppNotifications seems to have mostly been working for me, only giving a "can't start" notification at the same time as an actual notification whenever one was received, but today it just started repeatedly spamming me with the error non-stop.

Console shows this:

[InAppNotifications] Error! TypeError: Cannot read properties of undefined (reading 'isRawMessageMentioned')
    at plugin.supposedToNotify (VM579 InAppNotifications.plugin.js:998:50)
    at plugin.onMessage (VM579 InAppNotifications.plugin.js:811:21)
    at onMessage (VM579 InAppNotifications.plugin.js:599:15)
    at web.fbc721351be4d1055a8c.js:12:9580678
    at Set.forEach (<anonymous>)
    at web.fbc721351be4d1055a8c.js:12:9580667
    at web.fbc721351be4d1055a8c.js:12:9587105
    at h._dispatch (web.fbc721351be4d1055a8c.js:12:9580640)
    at web.fbc721351be4d1055a8c.js:12:9580152
    at l.log (web.fbc721351be4d1055a8c.js:12:9587047)
    at h._dispatchWithLogging (web.fbc721351be4d1055a8c.js:12:9580094)
    at h._dispatchWithDevtools (web.fbc721351be4d1055a8c.js:12:9579670)
    at Object.dispatch_MESSAGE_CREATE [as MESSAGE_CREATE] (web.fbc721351be4d1055a8c.js:12:9578984)
    at web.fbc721351be4d1055a8c.js:12:9579085
    at h.flushWaitQueue (web.fbc721351be4d1055a8c.js:12:9579566)
    at web.fbc721351be4d1055a8c.js:12:9579115
    at new Promise (<anonymous>)
    at h.dispatch (web.fbc721351be4d1055a8c.js:12:9578864)
    at h.dispatch (renderer.js:5:22880)
    at F (web.fbc721351be4d1055a8c.js:12:6131169)
    at Object.dispatch (web.fbc721351be4d1055a8c.js:12:6136904)
    at h.dispatchOne (web.fbc721351be4d1055a8c.js:12:6116972)
    at web.fbc721351be4d1055a8c.js:12:6115996
    at Array.forEach (<anonymous>)
    at web.fbc721351be4d1055a8c.js:12:6115951
    at e.batched (web.fbc721351be4d1055a8c.js:12:9584725)
    at h.dispatchMultiple (web.fbc721351be4d1055a8c.js:12:6115936)
    at flush (web.fbc721351be4d1055a8c.js:12:6117764)
    at E (sentry.47d15323f97d35a729c1.js:1:618129)

I tried the version in PR #398 and it seems to resolve the issue. Haven't tried #397

@tgrafk12
Copy link

agree on this, i havent seen this working since a large update a few weeks ago...
recently just had it spam me, I dont work messages and to join the discord for help, but you cant even click on it... :/

@thehamish555
Copy link

I tried the version in PR #398 and it seems to resolve the issue. Haven't tried #397

I have been using #398 since it came out, my PR was temporary thing that can be ignored, I just left it open incase the developers wanted to look into other approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants