Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the event types more robust #9

Open
L-Henke opened this issue May 13, 2015 · 3 comments
Open

Make the event types more robust #9

L-Henke opened this issue May 13, 2015 · 3 comments
Assignees

Comments

@L-Henke
Copy link
Contributor

L-Henke commented May 13, 2015

I think that the event type should be an Integer and not a string, because it is probably faster to switch on an integer than on a string. This is widely used in other event systems (e.g. Android request codes in startActivityForResult)

@thechauffeur
Copy link
Member

Maybe we should leave this for now. We need a process to register event types (e.g. for modules) anyway and could then improve the way this works.

@thechauffeur
Copy link
Member

We think about using objects for this. More thoughts are required about how to access an event type etc.

HOW TO:

  • differentiate event types
  • register event types

@thechauffeur thechauffeur changed the title Make event type an integer instead of a string Make the event types more robust Jun 1, 2015
@thechauffeur
Copy link
Member

@schulze and @L-Henke want to discuss this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants