Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players can see each other during character selection #226

Closed
Manason opened this issue Nov 4, 2023 · 6 comments
Closed

Players can see each other during character selection #226

Manason opened this issue Nov 4, 2023 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Manason
Copy link
Member

Manason commented Nov 4, 2023

Summary

Players are in the same bucket, so can see and hear each other when in the same character selection location

Reproduction

  1. Remove all character selection locations except for 1
  2. Have someone else load into character selection
  3. Load in yourself
  4. Observe that you can see each other and hear each other

Expected behavior

You wouldn't be able to see nor hear other players selecting characters

Actual behavior

You can see and hear other players selecting characters

Additional context

This is due to not putting players in different buckets on load-in due to a more severe bug associated with that. See #223

Last Updated

N/A

Custom Resources

N/A

Resource Rename

N/A

@Manason Manason added bug Something isn't working need repro This bug report needs confirmation labels Nov 4, 2023
@D4isDAVID D4isDAVID added this to Issues Nov 4, 2023
@github-project-automation github-project-automation bot moved this to Todo in Issues Nov 4, 2023
@alberttheprince
Copy link
Contributor

Is this still a bug? This is an unfortunate side effect of bucketing not working correctly correct? And why where the characters are kept and the camera displays the preview character are separate in multichar.

@Manason
Copy link
Member Author

Manason commented Nov 9, 2023

Is this still a bug? This is an unfortunate side effect of bucketing not working correctly correct? And why where the characters are kept and the camera displays the preview character are separate in multichar.

We intentionally turned off bucketing, because it was causing a more severe bug. This is still an open issue affecting those using the built-in multi char.

@Manason Manason added this to the 1.0.0 milestone Nov 13, 2023
@Manason Manason removed this from the 1.0.0 milestone Nov 16, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues Jan 3, 2024
@Manason Manason reopened this Jan 4, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Issues Jan 4, 2024
@Manason
Copy link
Member Author

Manason commented Jan 4, 2024

I don't believe this has yet been addressed. #248 was rolled back.

@ChatDisabled
Copy link
Member

Issue itself of routing buckets not working with oal has been fixed by Cfx citizenfx/fivem#2286

@Manason
Copy link
Member Author

Manason commented Jan 4, 2024

Issue itself of routing buckets not working with oal has been fixed by Cfx citizenfx/fivem#2286

Yes, but we still need to re-implement them.

@Manason Manason added good first issue Good for newcomers and removed need repro This bug report needs confirmation labels Mar 8, 2024
@mafewtm
Copy link
Member

mafewtm commented Apr 17, 2024

Should be fixed as of #445

@mafewtm mafewtm closed this as completed Apr 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

4 participants