Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up smallresources #43

Closed
Manason opened this issue Oct 2, 2023 · 4 comments
Closed

Break up smallresources #43

Manason opened this issue Oct 2, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Manason
Copy link
Member

Manason commented Oct 2, 2023

The problem

  • the config is confusing to navigate
  • servers may want some of the features but not all
  • lose out on features of resources like the ability to reload/disable
  • harms readability as all the files share the same resource visibility, so it's not guaranteed as a reader that there isn't a hidden global variable or function shared by two resources

Ideal solution

identify logical splits for where new resources should be created. Some examples:

qbx_afk - checks for afk players and kicks them
qbx_carwash - gives the carwashes around the map the ability to clean cars
qbx_binocular - creates a usable binocular item with zoom functionality

Alternative solutions

No response

Additional context

No response

@Manason Manason added the enhancement New feature or request label Oct 2, 2023
@D4isDAVID D4isDAVID added this to Issues Oct 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in Issues Oct 2, 2023
@alberttheprince
Copy link
Contributor

I agree - small resource should be very simple resources that can be reset with no impact on players/users. It should all fit within one or two files, basically a collect of snippets.

Why not just make a directory rather than a single resource that contains all these resources individually with their own fxmanifest?

@Manason
Copy link
Member Author

Manason commented Oct 11, 2023

I agree - small resource should be very simple resources that can be reset with no impact on players/users. It should all fit within one or two files, basically a collect of snippets.

Why not just make a directory rather than a single resource that contains all these resources individually with their own fxmanifest?

We could, and it would be an improvement for sure, but why do these snippets deserve to go together in the first place? If we were designing this structure from scratch, we wouldn't have any reason to group these resources together under a directory. They have nothing to do with each other aside from their size, but I don't think size is a useful organization paradigm.

@alberttheprince
Copy link
Contributor

As far as I've seen from server management, group resources like this only purpose is for server owners to brag about how "little" resources they have on their server or to hide resources from the public. I'm not sure if there's any performance or organizational benefit, but I think you could just totally split all of them into individual resources and be done with it.

@artur-michalak
Copy link
Contributor

I have separated everything into subdirectories, I think this will help in further work.

@KostaZx KostaZx closed this as completed Aug 28, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants