Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle won't despawn if player gets out from the vehicle during a test drive #43

Closed
SKITTLE6969 opened this issue Nov 17, 2023 · 7 comments
Labels
bug Something isn't working need repro This bug report needs confirmation

Comments

@SKITTLE6969
Copy link
Contributor

Summary

Vehicle won't despawn if player gets out from the vehicle during a test drive

Reproduction

Go to PDM
Start a Test drive
Get out from vehicle

Expected behavior

vehicle to be deleted and test drive timer to end

Actual behavior

test drive timer continues and can be abused to not let the vehicle despawn

Additional context

No response

Last Updated

11/17/23

Custom Resources

all vanilla

Resource Rename

no

@SKITTLE6969 SKITTLE6969 added bug Something isn't working need repro This bug report needs confirmation labels Nov 17, 2023
@D4isDAVID D4isDAVID added this to Issues Nov 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in Issues Nov 17, 2023
@SKITTLE6969
Copy link
Contributor Author

image

@mafewtm
Copy link
Member

mafewtm commented Nov 18, 2023

The vehicle is supposed to remain for a certain period of time, no? Affording the player the allotted time to finish the test drive even if, for some reason, they step out of the car or get ejected out of the car? I don't think the vehicle should automatically despawn if they step out of the vehicle before the allotted time is up.

@Manason
Copy link
Contributor

Manason commented Nov 18, 2023

The vehicle is supposed to remain for a certain period of time, no? Affording the player the allotted time to finish the test drive even if, for some reason, they step out of the car or get ejected out of the car? I don't think the vehicle should automatically despawn if they step out of the vehicle before the allotted time is up.

I think we should introduce a realism feature so you actually have to bring the vehicle back. And we have like a second timer for that; if not the police are called, and you get put on a blacklist for a configurable amount of time from test driving in the future.

@SKITTLE6969
Copy link
Contributor Author

Adding realism is good but people used to abuse this and spawn alot of cars and use them for ciminal acitivities, if we can make it so that no matter what player does, the vehicle despawns after the time, im good with it! :D

@mafewtm
Copy link
Member

mafewtm commented Nov 19, 2023

Theres only so much we can do to deal with what server owners and staff should be doing before it takes away from the script itself.

@Manason
Copy link
Contributor

Manason commented Nov 19, 2023

I don't think gating this type of feature behind a config option hurts.

@dusan01
Copy link

dusan01 commented Dec 3, 2023

Tested this, and the vehicle despawns after the time is over no matter if you are in the vehicle or out of the vehicle.

@dusan01 dusan01 closed this as completed Dec 16, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need repro This bug report needs confirmation
Projects
Status: Done
Development

No branches or pull requests

4 participants