Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add statebag for vehicle sales and gifts #51

Closed
solareon opened this issue Dec 21, 2023 · 3 comments · Fixed by #67
Closed

Add statebag for vehicle sales and gifts #51

solareon opened this issue Dec 21, 2023 · 3 comments · Fixed by #67
Assignees
@TonybynMp4
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@solareon
Copy link
Contributor

The problem

Currently selling a vehicle after #50 pops up a dialog box on the recipients end to confirm/deny the sale. This isn't clean or nice for the user.

Ideal solution

A solution using statebags where the prospective buyer/giftee would target the vehicle and make an offer through an input box and then the seller would also target the vehicle and then accept/decline the offer. This could be made further flexible by allowing multiple offers to exist on a vehicle and then providing the seller with a context menu or something of the sort to pick the offer.

Alternative solutions

No response

Additional context

No response
@solareon solareon added enhancement New feature or request good first issue Good for newcomers labels Dec 21, 2023
@qbox-duck qbox-duck bot added this to Issues Dec 21, 2023
@github-project-automation github-project-automation bot moved this to Todo in Issues Dec 21, 2023
@TonybynMp4
Copy link
Contributor

Could also consider using NPWD's notification API for that 🤔 (as an option ofc)

@Manason
Copy link
Contributor

Manason commented Feb 28, 2024

I like this idea.

@TonybynMp4 TonybynMp4 self-assigned this Mar 18, 2024
@TonybynMp4
Copy link
Contributor

I'll try and add it then

@TonybynMp4 TonybynMp4 moved this from Todo to In Progress in Issues Mar 20, 2024
@TonybynMp4 TonybynMp4 linked a pull request Mar 30, 2024 that will close this issue
feat: transfervehicle using phone notifications & small fixes #67
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TonybynMp4 TonybynMp4

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: transfervehicle using phone notifications & small fixes Qbox-project/qbx_vehicleshop
3 participants
@solareon @Manason @TonybynMp4