From 1430deeb5b7d644b3287ddda898bc0d0a60ba58f Mon Sep 17 00:00:00 2001 From: jiangxinglei Date: Tue, 22 Oct 2024 23:15:08 +0800 Subject: [PATCH] remove comments --- core/kernels/bn_table_ops.cc | 5 +---- core/ps/table/bn_table.cc | 3 --- core/ps/table/bn_table.h | 7 +++---- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/core/kernels/bn_table_ops.cc b/core/kernels/bn_table_ops.cc index 18034ae..a83aca8 100644 --- a/core/kernels/bn_table_ops.cc +++ b/core/kernels/bn_table_ops.cc @@ -104,16 +104,13 @@ class BnStatisticsPushKernel : public AsyncOpKernel { double* dynamic_double_data = new double[num_elements]; const float* float_data = var_tensor->flat().data(); for (int i = 0; i < num_elements; ++i) { - // std::cout << "float data is: " << float_data[i] << std::endl; dynamic_double_data[i] = static_cast(float_data[i]); - // std::cout << "double data is: " << dynamic_double_data[i] << std::endl; } acc_buf.append_user_data(dynamic_double_data, num_elements * sizeof(double), NoOpDeleter); - // acc_buf.append_user_data(var_tensor->flat().data(), var_tensor->NumElements() * sizeof(float), NoOpDeleter); allocated_pointers.push_back(dynamic_double_data); } - BnTable* table = BnTableRegistry::Instance()->Get(table_handle_); + BnTable* table = BnTableRegistry::Instance()->Get(table_handle_); table->Append(acc_buf, true); for (auto ptr : allocated_pointers) { diff --git a/core/ps/table/bn_table.cc b/core/ps/table/bn_table.cc index f463941..b5d842b 100644 --- a/core/ps/table/bn_table.cc +++ b/core/ps/table/bn_table.cc @@ -73,9 +73,6 @@ void BnTable::Append(butil::IOBuf& bn_statistics_buf, bool isLocal) { uint64_t cur_count = static_cast(total_count_.maxCoeff()); - // std::cout << "cur_count is : " << cur_count << std::endl; - // PrintDetail(); - // std::cout << "acc_count is : " << acc_count(0) << std::endl; if(max_count_ > 0 && cur_count > max_count_) { uint64_t acc_count_num = static_cast(acc_count.maxCoeff()); double ratio = (double) acc_count_num / cur_count; diff --git a/core/ps/table/bn_table.h b/core/ps/table/bn_table.h index f4b5b4f..7522145 100644 --- a/core/ps/table/bn_table.h +++ b/core/ps/table/bn_table.h @@ -75,11 +75,10 @@ class BnTable { Eigen::ArrayXd total_squared_sum_; Eigen::ArrayXd total_squared_sum_err_; Eigen::ArrayXd total_count_; - Eigen::ArrayXd inc_sum_; - Eigen::ArrayXd inc_squared_sum_; - Eigen::ArrayXd inc_count_; + Eigen::ArrayXd inc_sum_; + Eigen::ArrayXd inc_squared_sum_; + Eigen::ArrayXd inc_count_; std::unique_ptr mu_; - }; class BnTableRegistry {