Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows broken for nb-tester due to pyscf #2576

Closed
Eric-Arellano opened this issue Jan 15, 2025 · 0 comments · Fixed by #2595
Closed

Windows broken for nb-tester due to pyscf #2576

Eric-Arellano opened this issue Jan 15, 2025 · 0 comments · Fixed by #2595

Comments

@Eric-Arellano
Copy link
Collaborator

Eric-Arellano commented Jan 15, 2025

#2148 added pyscf as a dependency, although it's only used in docs/guides/qiskit-addons-sqd-get-started.ipynb.

This breaks Windows users because https://pypi.org/project/pyscf/#files doesn't support Windows. So, Windows users can't run tox for our nb-tester program.

We should use an env marker like tweedledum; platform_system != "Darwin" to not install pyscf on Windows. We should also consider somehow indicating with nb-tester config that the notebook doesn't work on Windows so that you can still use tox to execute all notebooks.

Update Jan 23, 2025: We should go for the quick fix to use an env marker like ; platform_system != "Darwin" (but Windows). It's acceptable that tox won't work for every notebook; we don't need to know to skip that notebook on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants