Bump supported OrdinaryDiffEq version to anything < 6.58.0 #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OrdinaryDiffEq a minor version higher
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
- Coverage 76.65% 73.67% -2.98%
==========================================
Files 94 60 -34
Lines 4801 3556 -1245
==========================================
- Hits 3680 2620 -1060
+ Misses 1121 936 -185 ☔ View full report in Codecov by Sentry. |
Roger-luo
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior testing shows that for now, any version of OrdinaryDiffEq less than 6.58 works. The choice to restrict to < 6.57 came from some confusion over #615 where it was assumed < 6.57 would fix an (unrelated) issue with BloqadeKrylov.
This is temporary solution while I work on removing our dependence on the internal
__init.The dependency on SimpleNonlinearSolve has also been removed.