Removing dependency on BloqadeODE in BloqadeKrylov tests. #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
==========================================
- Coverage 77.30% 76.86% -0.45%
==========================================
Files 93 104 +11
Lines 4609 5251 +642
==========================================
+ Hits 3563 4036 +473
- Misses 1046 1215 +169 ☔ View full report in Codecov by Sentry. |
johnzl-777
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some unneccesary dependencies on BloqadeLattice and BloqadeWaveforms but I believe these are there so that the CI passes as well. Since they are light weight packages I am willing to leave them here until I can do a new release with some of the bug fixes that are currently on the master branch.