Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Tags attribute to all deployment option #24

Open
Costya-Y opened this issue Aug 4, 2020 · 1 comment
Open

Add Custom Tags attribute to all deployment option #24

Costya-Y opened this issue Aug 4, 2020 · 1 comment

Comments

@Costya-Y
Copy link
Collaborator

Costya-Y commented Aug 4, 2020

@alexazarh commented on Thu Oct 20 2016

We need to let the user define custom tags. Up to 9 custom tags. Because Azure limit is 15 and we already use 6 tags for every object.

The custom tags should be applied to the VM and all related objects that are created during the app deploy

Add an attribute "Custom Tags" that will support the following syntax (comma separated list):
[TagName]=[TagValue], [TagName]=[TagValue]
Example:
Tag1=Val1, Tag2=Val2


@TomerAdmon commented on Thu Dec 15 2016

validations - if the content of the attribute doesn't fit the above syntax we should fail the deploy of the app and throw a message to the user (output console) that the custom tags defined on this app were invalid. this should be shown both when deploying a single app or deploying apps as part of the Setup.


@alexazarh commented on Wed Dec 21 2016

Dont merge it to develop before we create a release branch

@TomerAdmon
Copy link

@Costya-Y - Can you set a grooming session for this together with product and make sure we understand this from every direction (documentation, announcements, ect)...
As far as i understand, as we will need some changes in the Quali Server, we also need to prioritize it internally in CloudShell Pro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants