Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axios 0.28 on Stage breaks dataset search. #176

Open
adam3smith opened this issue Jul 16, 2024 · 4 comments
Open

Axios 0.28 on Stage breaks dataset search. #176

adam3smith opened this issue Jul 16, 2024 · 4 comments
Assignees

Comments

@adam3smith
Copy link
Contributor

Due to axios/axios#4734
the requests to the mydata Dataverse API on stage include [] in the publicationStatus terms, so
published_states[]=Published&published_states[]=Unpublished&published_states[]=Draft&published_states[]=In+Review
instead of the correct
published_states=Published&published_states=Unpublished&published_states=Draft&published_states=In%20Review

This breaks all dataset searches, both for ATI projects and for projects to turn into ATI projects

@adam3smith
Copy link
Contributor Author

Comment from Jim:

Sounds good. He may have tried to fix it with

return qs.stringify(params, { indices: false })
- not sure if it needs a different spelling as suggested by axios/axios#1443 (comment).

@tohuynh
Copy link
Collaborator

tohuynh commented Jul 18, 2024

The upgrade to axios version must have made qs.stringify(params, { indices: false }) no longer removes []s. I'll try to take a look at the issue sometime this weekend if it's not urgent.

@adam3smith
Copy link
Contributor Author

adam3smith commented Jul 18, 2024 via email

@tohuynh
Copy link
Collaborator

tohuynh commented Jul 23, 2024

It looks like 0.28.0 made breaking changes and paramsSerializer can longer be a function. The fix is supposedly in 0.28.1, I'll see if that fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants