Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headings in blog posts #874

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix headings in blog posts #874

wants to merge 1 commit into from

Conversation

gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Aug 23, 2024

See PR #873 for some context.

Our blog post build code takes the blog title from the post metadata and renders it both in the HTML <title> tag as well as at the top of the page (in an <h1> after #873). For this reason, the body of the blog post markdown should not contain any level-1 headings, only level-2 and up.

Most blog posts in the repo have been written this way, but there were some exceptions that this PR attempts to correct.

Note: my editor also introduced a number of formatting and whitespace changes. If these add too much review burden, please let me know and I'll redo the PR so that it strictly only has heading changes.

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
labs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 9:52am

@gabalafou
Copy link
Contributor Author

Attempting to self-review this PR, I realize that my editor's auto-formatting added too many changes. I'm going to redo and update this PR.

@gabalafou gabalafou marked this pull request as draft August 23, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant