Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[search] feedback on 0.5.0 #210

Open
mmcky opened this issue May 4, 2023 · 4 comments
Open

[search] feedback on 0.5.0 #210

mmcky opened this issue May 4, 2023 · 4 comments
Assignees
@DrDrij @AakashGfude

Comments

@mmcky
Copy link
Contributor

mmcky commented May 4, 2023

Here are some minor feedback points on 0.5.0 testing

It would good to tidy up the x when opening the box so that it doesn't clash with the search icon

Screenshot 2023-05-04 at 11 00 38 am

@DrDrij has some comments around compatibility with mobile etc. re: css
@mmcky
Copy link
Contributor Author

mmcky commented May 4, 2023

Test deployment of lecture-python-programming is available here

https://6453038377900a224cc83f30--epic-agnesi-957267.netlify.app/search.html?q=python

@mmcky mmcky mentioned this issue May 4, 2023
Closed
@DrDrij
Copy link
Member

DrDrij commented May 4, 2023

Just writing the styles now :)

@AakashGfude
Copy link
Member

Thanks @DrDrij and @mmcky

@mmcky
Copy link
Contributor Author

mmcky commented May 18, 2023

@DrDrij no particular rush on this -- but let @AakashGfude if you need him to make any updates etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DrDrij DrDrij

@AakashGfude AakashGfude

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DrDrij @AakashGfude @mmcky