Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get the list of drives and their contents #15

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

HaudinFlorence
Copy link
Member

@HaudinFlorence HaudinFlorence commented Jan 19, 2024

This PR tries the connection between backend and frontend and tries to:

  • get the list the available drives
  • mount a specific drive
  • get the content of this drive.

Copy link

Binder 👈 Launch a Binder on branch HaudinFlorence/jupyter-drives/try_to_get_drive_contents

@HaudinFlorence HaudinFlorence added the enhancement New feature or request label Jan 19, 2024
@HaudinFlorence HaudinFlorence force-pushed the try_to_get_drive_contents branch 5 times, most recently from dce7bb9 to 410d05b Compare March 11, 2024 16:30
@HaudinFlorence HaudinFlorence force-pushed the try_to_get_drive_contents branch 5 times, most recently from 3017d48 to 3a3ca31 Compare March 18, 2024 13:47
…with the default file browser and the added drive one.
…ddDrivesPlugin and moved hard coded inputs mimicking backend side inputs , outside from the plugins and methods.
Add logics to add the content of the drive to the filebrowser when adding a drive in the dialog.
…nterface, when picking a drive by its name in the list of available drives.

Add a toolbar to all the drive filebrowsers.
Create a BreadCrumbsLayout to enable to have the breadcrumbs inside the AccordionPanel title section
…multidrivesbrowser.ts, dirlisting.ts -> drivelisting.ts. Restore in index.ts a proper logics to add the content of an added driveBrowser to the multidrives browser when a drive is selected and added in the dialog.
…multidrivesbrowser.ts, dirlisting.ts -> drivelisting.ts. Restore in index.ts a proper logics to add the content of an added driveBrowser to the multidrives browser when a drive is selected and added in the dialog.
…nd update index.ts and drivelistmanager to be able to add and remove panels containing drive filebrowsers for drives selected in the dialog.
…nt a drive. Try to get the content of this drive.
…t the content of a drive.

Update index.ts.
Update the get method of the Drive class in contents.ts to populate the drive filebrowser with the contents from the respective s3 bucket.
Change the icon for the drive filebrowser.
@HaudinFlorence HaudinFlorence force-pushed the try_to_get_drive_contents branch 14 times, most recently from 8d508fa to 2264322 Compare March 20, 2024 10:46
@jtpio
Copy link
Member

jtpio commented Mar 20, 2024

Checking the UI tests report, it looks like the plugin does not activate due to:

Failed to load resource: the server responded with a status of 400 (No AWS credentials specified. Please set them in your user jupyter_server_config file.)
playwright-trace-demo.webm

@HaudinFlorence HaudinFlorence force-pushed the try_to_get_drive_contents branch 2 times, most recently from 6acf446 to 0113eea Compare March 20, 2024 11:27
@HaudinFlorence
Copy link
Member Author

HaudinFlorence commented Mar 20, 2024

@jtpio Thanks for the screenshot and the help. It appears indeed that the activation message is not properly placed.

Temporarily disable the browser-check test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants