-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Roadmap] ideas about taking another dependency for generating notes #8
Comments
Get rid of Anki Connect? Sounds like a plan. Let's have a try. |
Hi @serifold , glad to see u again. I have invited u to become a collaborator of this proj. If ur happy with it u can accept it and start to have direct access to this repo, otherwise u can still contribute to this repo through ur fork and commit PR to it. Either way is good, thx 4 ur interest. |
Hi @Quasimurdock, thanks for your trust and appreciation, I'm very glad to become a collaborator of this project.🤝 |
Good night @Quasimurdock, I have tried
|
@serifold Hi, appreciate ur efforts of figuring out how is it like about As for replacing And am I right that ur saying that we actually have a chance to modify |
Hi @Quasimurdock, yeah, if we all agree to continue using CLI to generate deck, then we could learn from However, currently I'm not quite sure which package should we use, or even if do we really need a database package? By Node.js, we could read from HTML files already, all we need to do should be writing these data to a This weekend I'll take some time to read the source code of |
Hey @serifold , I found that For now, if u wanna test it, u can install it through: I updated the directory structure of our repo and now it's more extensible for adding But I don't know if |
Good night, @Quasimurdock. Thanks for the reminding. Indeed, A original Node.js side package is much more convenient than a browser side one for our project. I have made a fork from @kizaski/mkanki too, and I have made some modifications to make this forked version of So far, it still has a bug that all However, I tried use it in our project for some time, but I still can't make it. It always generates a blank deck. I think this could be a async relevant bug, but still I couldn't solve it... If you don't mind, I'll push a Up until now, I think this solution is feasible, these bugs don't seem to be impossible to solve. If you think so, we could focus on solving the bugs, or we could find some other solutions. |
Yeah, I think we can figure out what's going on to these two issues.
Great, plz go ahead! |
OK, I have pushed |
Hi, @serifold. I checkout to the But it pops out a window saying 'Notes found in file: 0', the size of this apkg file is 69KB. Is there any problem with it? |
That's what I said 'a blank deck' means. There is nothing in that deck. In the function async function convert() {
await processHtmlFiles();
package.addDeck(deck);
package.writeToFile('test.apkg');
} But it seems that And one of the major part of |
Hey @serifold ! I've pushed a new branch Ur judgements above r right. So I looked into After we cleaning up & revising the code on I've committed a PR to merge dev #9 u can review it now |
found a new issue related to tags of cards: now every note's tags field only include a will check it. found it lies in previous changes in I've already committed a PR here which is adapted from this, after ur check make sure it updated to primary branch and update dependency of this proj. |
So far everythin works fine to me, notify me if u have any latest discoveries |
👍Cool, good job🔥. I just finished review, it's too late, I must go to sleep now😵. I'll share more my thoughts at daytime. |
Thanks for the trouble shooting, I improved the comprehension of JS promise api a lot. At that time, I thought about using some Node.js promise api such as
Yeah, we could keep both, that's also what I thought. Then the
Thanks for your PR, I'll review it and try to figure out what's wrong in my original codes.
It's really good. However, Except for the date bug, I found another glitch: The order of |
Isn't that managed by Anki's spaced repetition mechanism? I thought they're
And about this created date issue I forgot it sorry 😂 This field won't affect the use of notes right? So I assume it not a big problem. But yeah it's better to make it right. |
Suddenly I realized this The date in the bottom might be the old Anki Connect version's We are also using Anki Connect, and I have executed many tests, as a result, my recently added ODH cards' Looks like just a Anki Connect feature which is not much practical, perhaps we could try to apply this feature to our project in our spare time. Low priority. |
Duplicate pictures uploaded... Now updated.
Yeah, it's not serious. But I just can't put up with bugs which were discovered and unsolved. As long as it's not impossible to solve, I always want to try to fix it to improve the code quality... |
Other questions like created date, README updates or error hints shall be opened in new issues. |
Found genanki-js just now. It's a JS implementation of genanki, which allows us to programatically generate decks for Anki.
For now
html2notes.js
is actually to create a new deck and note type, then import HTML files fetched in the former step directly into users' Anki with anki-connect API. We actually encountered some problems in this way, which has been discussed in #3 . It looks like hard to solve, so I'm thinking about taking genanki-js for the process of converting and importing notes. In that case, we can simply generate.apkg
packages and leave the task of importing to users.This repo is actually named
Generater
instead of an importing tool. Moreover, the most important is the issue previously mentioned could be avoided since generatingapkg
files and manually importing them is way more steady than the whole steps of taking anki-connect API to connect with your opening Anki program and invoking those importing related methodsThe text was updated successfully, but these errors were encountered: