Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qvm-prefs does not hide defaults if key is specified #8615

Open
ben-grande opened this issue Oct 16, 2023 · 3 comments · May be fixed by QubesOS/qubes-core-admin-client#302
Open

qvm-prefs does not hide defaults if key is specified #8615

ben-grande opened this issue Oct 16, 2023 · 3 comments · May be fixed by QubesOS/qubes-core-admin-client#302
Assignees
@alimirjamali
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: minor Priority: minor. The lowest priority, below "default." pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@ben-grande
Copy link

How to file a helpful issue

Qubes OS release

R4.1

Brief summary

When specifying --hide-default it conflicts with the key specified, printing incorrect information.

Steps to reproduce

Try to see if qube netvm is set to default or not (the netvm of this qube is the default):

qvm-prefs QUBE | grep "^netvm\s\+D\s\+" # exit 0 - prints the whole line
qvm-prefs QUBE | grep "^netvm\s\+D\s\+" | awk '{print $3}' # exit 0 - prints netvm but does not fail on pipes depeding on shell options
qvm-prefs --hide-default QUBE | grep netvm   # exit 1 - prints nothing, expected
qvm-prefs --hide-default QUBE netvm  # exit 0 - prints netvm, should not print
qvm-prefs QUBE netvm # exit 0 - prints netvm, this is okay

So... how can one know that the netvm of a qube is using the default value for netvm without parsing the output?

Expected behavior

qvm-prefs --hide-default QUBE netvm

Should fail if netvm is the default.

Actual behavior

qvm-prefs --hide-default QUBE netvm

Prints the netvm name, even though it is the default value.
@ben-grande ben-grande added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Oct 16, 2023
@andrewdavidwong andrewdavidwong added C: core needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. affects-4.1 This issue affects Qubes OS 4.1. labels Oct 17, 2023
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Jul 27, 2024
@alimirjamali
Hide qvm-prefs default value with --hide-default
cc57577 
fixes: QubesOS/qubes-issues#8615
@alimirjamali alimirjamali linked a pull request Jul 27, 2024 that will close this issue
Open
@alimirjamali
Copy link

PR submitted

@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Jul 28, 2024
@andrewdavidwong
Copy link
Member

PR submitted

Does that mean this also affects 4.2?

@alimirjamali
Copy link

Does that mean this also affects 4.2?

Yes. It does. But it is a minor issue

@andrewdavidwong andrewdavidwong added P: minor Priority: minor. The lowest priority, below "default." affects-4.2 This issue affects Qubes OS 4.2. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Jul 29, 2024
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Aug 8, 2024
@alimirjamali
Hide qvm-prefs default value with --hide-default
8b305c0 
fixes: QubesOS/qubes-issues#8615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimirjamali alimirjamali

Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: minor Priority: minor. The lowest priority, below "default." pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide qvm-prefs default value with --hide-default alimirjamali/qubes-core-admin-client
3 participants
@alimirjamali @andrewdavidwong @ben-grande