Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add POOL as an available column in qvm-ls #5138

Closed
brendanhoar opened this issue Jul 1, 2019 · 3 comments · Fixed by QubesOS/qubes-core-admin-client#306
Closed

Add POOL as an available column in qvm-ls #5138

brendanhoar opened this issue Jul 1, 2019 · 3 comments · Fixed by QubesOS/qubes-core-admin-client#306
Assignees
@alimirjamali
Labels
C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.

Comments

@brendanhoar
Copy link

The problem you're addressing (if any)
Quickly find which LVM pool a VM belongs to.

Describe the solution you'd like
Add a column to the supported --fields list that qvm-ls supports.

Where is the value to a user, and who might that user be?
Any user who uses multiple pools should have a quick way to query which VMs are located on which pool.

Describe alternatives you've considered
Both qvm-volume list and sudo lvs can indirectly indicate the pool.
@brendanhoar brendanhoar added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. labels Jul 1, 2019
@andrewdavidwong andrewdavidwong added this to the Release 4.1 milestone Jul 1, 2019
@marmarek
Copy link
Member

marmarek commented Jul 3, 2019

This require a little clarification, since VMs have 4 volumes and each can be in a different pool. I think the most sense would be listing a pool of "private volume". Is it what you have in mind?

@brendanhoar
Copy link
Author

brendanhoar commented Jul 4, 2019 •
edited
Loading

Ah, good point, I did not consider this, as there's no VM-specific "pool" setting. It's just where the volumes are.

Private volume's pool might be the best single indicator. Or...maybe change my request to "Add POOLS as an available column in qvm-ls" and return a comma delimited list of the pools utilized by all of the non-kernel volumes?

B

@andrewdavidwong andrewdavidwong removed this from the Release 4.2 milestone Aug 13, 2023
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Sep 1, 2024
@alimirjamali
Add PRIV-POOL & ROOT-POOL columns to qvm-ls
4ea481f 
resolves: QubesOS/qubes-issues#5138
@alimirjamali alimirjamali mentioned this issue Sep 1, 2024
Merged
@alimirjamali
Copy link

PR Submitted

Review priority: low

PRIV-POOL & ROOT-POOL columns are added. I do not believe Kernel & Volatile pools to be very much necessary. But they are also possible.

@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimirjamali alimirjamali

Labels
C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PRIV-POOL & ROOT-POOL columns to qvm-ls alimirjamali/qubes-core-admin-client
4 participants
@marmarek @alimirjamali @brendanhoar @andrewdavidwong