-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to hide (a) qube(s) from updates #9029
Ability to hide (a) qube(s) from updates #9029
Comments
Some binary prefs like |
I wonder if this is what the
However it cannot be changed by the user. I wonder what the reasoning is (maybe footshooting prevention).
|
Ok. This issue is relatively easy to solve. I am going to work on this. The design is going to be like this:
Overall it is very simple. But more than one PR will be necessary. p.s.: Since this will be an advanced feature and niche area which is most probably not used by most users, I believe it is better to avoid adding it to |
Nice! Happy to see some momentum on this.
Meta question: should this be a feature or a preference? I often confused both, but in my head qube preferences are well defined whereas as features are more open-ended. In particular (especially if something that exists natively -- like this case), with preferences one can list / discover all available by running Anyways, just my two cents. I may be wrong on the distinction, though. |
This is a very good question :) We don't have any guidelines for this, and we don't use it consistently really (*)...
Generally, properties are smarter. But due to its stricter nature, and potentially smarter behavior, need more care when implementing. This also means committing to its support in the future, converting on upgrades, while restoring old backups in the future etc. More or less it means you cannot really remove it in the future - at least some migration code needs to stay forever. There was a plan to make features a bit smarter, especially around their documentation and value validation (basically have an API that allows adding extra metadata to some feature names). But that mechanism never materialized and the only thing we have is the In this particular case, I think it's okay to go with a feature, especially since (*) one one hand |
That makes sense. Thanks a lot for the clarification. Feature it is :) |
In the last few hours, I considered patching Finally I decided to revert back to the original plan. |
The PRs (total of 3) for this issue are ready for review. Review priority: low
Video demo: skip_update.mp4 |
I'm reviewing the PRs and I wonder if 4. is not too many layers of hiding - I feel like showing advanced settings (while marking them as advanced) by default is not a bad idea? It still requires CLI command to actually set on a VM, right? |
We discussed this on forum. We were/are afraid if novice users might use this potentially dangerous feature and end up with many outdated templates. But reconsidering it, maybe it is not that bad. I will remove |
The problem you're addressing (if any)
I have several qubes which are never going to receive updates - currently these qubes are visible in the update manager, but they are clutter
The solution you'd like
The ability to hide (a) qube(s) from the updating functionality
The value to a user, and who that user might be
It means we can select all in the update manager rather than having to choose qubes individually. This will benefit anyone running a Windows 10/11 HVM, TempleOS, or a number of other guests such as the mirage-os unikernel.
The text was updated successfully, but these errors were encountered: