Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with NavigationTransition name in iOS 18 and XCoordinator #250

Open
tashyeghiazaryan opened this issue Nov 7, 2024 · 0 comments

Comments

@tashyeghiazaryan
Copy link

Title: Naming Conflict with NavigationTransition in XCoordinator and iOS 18

Description:

I've noticed an issue with the NavigationTransition name used in XCoordinator, which now conflicts with iOS 18's newly introduced NavigationTransition API. This overlap causes naming conflicts, making it challenging to work with the library in projects targeting iOS 18 or later.

Problem
When using XCoordinator in projects on iOS 18, the NavigationTransition name conflicts with the new iOS API, leading to ambiguity and requiring workarounds to avoid naming clashes.

Proposed Solution
Could you consider renaming NavigationTransition in XCoordinator to avoid this conflict? A few potential names that still capture the purpose of this type include:

XCNavigationTransition
CoordinatorNavigationTransition
Updating the name would improve compatibility with iOS 18 and help avoid conflicts for developers using both iOS frameworks and XCoordinator in their projects.

Thank you for all your hard work on this project and for considering this update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant